Messages in this thread | | | From | "wufan" <> | Subject | RE: [PATCH] EDAC, ghes: use CPER module handles to locate DIMMs | Date | Thu, 30 Aug 2018 10:45:03 -0600 |
| |
Hi James,
> > For ghes_edac the bank/device is informational, and nothing would go > > wrong if the bank/device numbers are the same as another entry. But > > the handle is now critical for DIMM lookup, thus pull it out. > > Is printing the handle to the kernel log critical? > > I'd expect something collecting errors to read from sysfs, not dmesg. I > thought the whole point here was to update the per-dimm counters in sysfs.
No, printing out the handle is not critical. What I meant is because the information is critical it would be nice to have it available for debugging purpose. Otherwise it would be hard to find the handle if bank/device is not accurate.
Thanks, Fan
| |