Messages in this thread | | | Date | Thu, 30 Aug 2018 11:44:52 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH tip/core/rcu 0/52] Remove rcu_state pointers for v4.20/v5.0 |
| |
On Wed, 29 Aug 2018 21:10:17 -0700 "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote:
> On Wed, Aug 29, 2018 at 08:22:16PM -0700, Paul E. McKenney wrote: > > On Wed, Aug 29, 2018 at 10:00:26PM -0400, Steven Rostedt wrote: > > > On Wed, 29 Aug 2018 15:38:30 -0700 > > > "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote: > > > > > > > Hello! > > > > > > > > This commit does RCU-consolidation cleanups that get rid of pointers to > > > > the sole remaining rcu_state structure: > > > > > > > > 1-40: Remove the "rsp" parameter from numerous functions, given that > > > > the corresponding argument will always be &rcu_state. > > > > > > Hmm, couldn't 1-40 have been made into a single patch? > > > > They could. I separated them to make finding the inevitable typos easier. > > But at this point, it is easy enough to squash them together, though. > > And please see below for what the resulting diff would look like. Is > this an improvement?
Somewhat...
> > Thanx, Paul > > ------------------------------------------------------------------------ > > diff --git a/Documentation/RCU/Design/Data-Structures/Data-Structures.html b/Documentation/RCU/Design/Data-Structures/Data-Structures.html > index f5120a00f511..772c26a3865a 100644 > --- a/Documentation/RCU/Design/Data-Structures/Data-Structures.html > +++ b/Documentation/RCU/Design/Data-Structures/Data-Structures.html
I would just keep the documentation patches separate.
-- Steve
> @@ -1372,8 +1372,7 @@ that is, if the CPU is currently idle. > Accessor Functions</a></h3> > > <p>The following listing shows the > -<tt>rcu_get_root()</tt>, <tt>rcu_for_each_node_breadth_first</tt>, > -<tt>rcu_for_each_nonleaf_node_breadth_first()</tt>, and > +<tt>rcu_get_root()</tt>, <tt>rcu_for_each_node_breadth_first</tt> and > <tt>rcu_for_each_leaf_node()</tt> function and macros: > >
| |