lkml.org 
[lkml]   [2018]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/8] RISC-V: Rename riscv_of_processor_hart to riscv_of_processor_hartid
    > +/* Returns the hart ID of the given device tree node, or -1 if the device tree
    > + * node isn't a RISC-V hart. */

    In addition to the comment formatting: we usually keep the description
    near the implementation, not the header. It could also become a
    kerneldoc comment for added clarity.

    > +extern int riscv_of_processor_hartid(struct device_node *node);

    No need to declare function prototypes in headers with the extern
    attribute, btw.

    \
     
     \ /
      Last update: 2018-08-30 20:07    [W:2.533 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site