Messages in this thread | | | Date | Thu, 30 Aug 2018 11:23:05 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 01/21] staging:rtl8192u: Rename AdvCoding - Style |
| |
On Wed, Aug 29, 2018 at 09:35:27PM +0100, John Whitmore wrote: > Rename the bit field element AdvCoding, as it causes a checkpatch issue > with CamelCase naming. As the element is not actually used in code it > has been renamed to 'not_used_adv_coding'. > > The single line of code which initialises the bit has been removed, > as the field is unused. > > This is a purely coding style change which should have no impact > on runtime code execution. > > Signed-off-by: John Whitmore <johnfwhitmore@gmail.com> > --- > drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 2 +- > drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h > index 64d5359cf7e2..66a0274077d3 100644 > --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h > +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h > @@ -39,7 +39,7 @@ enum ht_extension_chan_offset { > > struct ht_capability_ele { > //HT capability info > - u8 AdvCoding:1; > + u8 not_used_adv_coding:1;
I can't review any more of this patchset when this is the first line...
:(
regards, dan carpenter
| |