lkml.org 
[lkml]   [2018]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [linux-sunxi] [PATCH v3 21/30] iio: adc: sun4i-gpadc-iio: add support for H3 thermal sensor
    From
    Date


    On 30.08.2018 22:00, Philipp Rossak wrote:
    > On 30.08.2018 18:27, Ondřej Jirman wrote:
    >>> +static int sun8i_h3_calibrate(struct sun4i_gpadc_iio *info)
    >>> +{
    >>> +//    regmap_write(info->regmap, SUNXI_THS_CDATA_0_1,
    >>> +//            info->calibration_data[0]);
    >>> +//    regmap_write(info->regmap, SUNXI_THS_CDATA_2_3,
    >>> +//            info->calibration_data[1]);
    >> This should probably be implemented, or left out completely.
    >>
    >> regards,
    >>    o.
    >>
    > Thanks you are right!
    > This should be implemented! I will fix this in the next version!
    >
    > Thanks,
    > Philipp

    I just realized this function need to check if calibration datas are
    available. Writing zeros to the calibration data regs "breaks" the
    thermal sensor.

    Philipp

    \
     
     \ /
      Last update: 2018-08-30 22:48    [W:4.979 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site