Messages in this thread | | | Date | Fri, 3 Aug 2018 22:18:16 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH 2/2] sparc32: tidy up ramdisk memory reservation |
| |
Hi Mike.
On Thu, Aug 02, 2018 at 02:53:53PM +0300, Mike Rapoport wrote: > The detection and reservation of ramdisk memory were separated to allow > bootmem bitmap initialization after the ramdisk boundaries are detected. > Since the bootmem initialization is removed, the reservation of ramdisk > memory can be done immediately after its boundaries are found.
When touching this area could you look at introducing a find_ramdisk() function like we do for sparc64? It is always nice when the codebases look alike. Then you could combine your simplification with some refactoring that further increases readability.
See: https://patchwork.ozlabs.org/patch/151194/ for my attempt from long time ago.
Sam
| |