Messages in this thread | | | Subject | Re: [PATCH] parisc: prefer _THIS_IP_ and _RET_IP_ statement expressions | From | John David Anglin <> | Date | Fri, 3 Aug 2018 15:09:57 -0400 |
| |
On 2018-08-03 2:11 PM, Nick Desaulniers wrote: > But the kernel uses the generic_THIS_IP_ *everywhere*, not parisc's > custom current_text_addr(). So if this did actually break unwinding, > you should have noticed by now. The unwind problem was noticed.
Patches were recently applied to gcc and binutils to try and fix it. The gcc patch moved branch tables to rodata so that the label at the head of the table wasn't in text.
https://gcc.gnu.org/ml/gcc-patches/2018-07/msg01804.html https://sourceware.org/ml/binutils/2018-07/msg00474.html
When I saw your suggested change, I realized there was another source of text labels that need linker relocations.
Dave
-- John David Anglin dave.anglin@bell.net
| |