Messages in this thread | | | From | valdis.kletnieks@vt ... | Subject | Re: [PATCH 11/11] ASoC: wm8994: Mark expected switch fall-through | Date | Fri, 03 Aug 2018 13:55:18 -0400 |
| |
On Fri, 03 Aug 2018 11:56:12 -0500, "Gustavo A. R. Silva" said: > On 08/03/2018 11:45 AM, Mark Brown wrote: > > Basically nobody ever uses OPCLK so I'd be susprised if anyone ever > > noticed.
I wonder if nobody uses it because any attempts to do so get an error? :)
> I see. I wonder what's the best approach in this case. Should that code be > removed instead of 'fixed'?
I'm thinking that's a spot that needs a 'break;' added.
Of course, my understanding of that code is limited to looking at the first 10 patches and the fall-through hit something reasonable, and then the last one did a fall-through to an error return. [unhandled content-type:application/pgp-signature] | |