Messages in this thread Patch in this message | | | From | "Verma, Vishal L" <> | Subject | Re: [PATCH] libnvdimm, bus: check id immediately following ida_simple_get | Date | Fri, 3 Aug 2018 17:13:39 +0000 |
| |
On Fri, 2018-08-03 at 08:08 -0400, Ocean He wrote: > From: Ocean He <hehy1@lenovo.com> > > The id check was not executed immediately following ida_simple_get. > Just > change the codes position, without function change. > > Signed-off-by: Ocean He <hehy1@lenovo.com> > --- > drivers/nvdimm/bus.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
Looks good, feel free to add Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
> > diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c > index 27902a8..ab28e7c 100644 > --- a/drivers/nvdimm/bus.c > +++ b/drivers/nvdimm/bus.c > @@ -350,12 +350,12 @@ struct nvdimm_bus *nvdimm_bus_register(struct > device *parent, > INIT_LIST_HEAD(&nvdimm_bus->mapping_list); > init_waitqueue_head(&nvdimm_bus->probe_wait); > nvdimm_bus->id = ida_simple_get(&nd_ida, 0, 0, GFP_KERNEL); > - mutex_init(&nvdimm_bus->reconfig_mutex); > - badrange_init(&nvdimm_bus->badrange); > if (nvdimm_bus->id < 0) { > kfree(nvdimm_bus); > return NULL; > } > + mutex_init(&nvdimm_bus->reconfig_mutex); > + badrange_init(&nvdimm_bus->badrange); > nvdimm_bus->nd_desc = nd_desc; > nvdimm_bus->dev.parent = parent; > nvdimm_bus->dev.release = nvdimm_bus_release;
| |