Messages in this thread | | | Date | Fri, 03 Aug 2018 09:49:12 -0700 (PDT) | Subject | Re: [PATCH net-next] rxrpc: Reuse SKCIPHER_REQUEST_ON_STACK buffer | From | David Miller <> |
| |
From: David Howells <dhowells@redhat.com> Date: Fri, 03 Aug 2018 10:15:25 +0100
> From: Kees Cook <keescook@chromium.org> > > The use of SKCIPHER_REQUEST_ON_STACK() will trigger FRAME_WARN warnings > (when less than 2048) once the VLA is no longer hidden from the check: > > net/rxrpc/rxkad.c:398:1: warning: the frame size of 1152 bytes is larger than 1024 bytes [-Wframe-larger-than=] > net/rxrpc/rxkad.c:242:1: warning: the frame size of 1152 bytes is larger than 1024 bytes [-Wframe-larger-than=] > > This passes the initial SKCIPHER_REQUEST_ON_STACK allocation to the leaf > functions for reuse. Two requests allocated on the stack is not needed > when only one is used at a time. > > Signed-off-by: Kees Cook <keescook@chromium.org> > Acked-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: David Howells <dhowells@redhat.com>
Applied, thank you.
| |