Messages in this thread | | | Date | Fri, 3 Aug 2018 15:10:35 +0200 | From | Jean Delvare <> | Subject | native_save_fl() causes a warning |
| |
Hi Nick,
It seems that this linux kernel commit of yours:
commit d0a8d9378d16eb3c69bd8e6d23779fbdbee3a8c7 Author: Nick Desaulniers Date: Thu Jun 21 09:23:24 2018 -0700
x86/paravirt: Make native_save_fl() extern inline
introduced a new warning (with W=1):
./arch/x86/include/asm/irqflags.h:16:29: warning: no previous prototype for ‘native_save_fl’ [-Wmissing-prototypes] extern inline unsigned long native_save_fl(void) ^
Please fix it.
Secondly, I am quite curious why you changed only native_save_fl() from static inline to extern inline, when native_restore_fl(), native_irq_disable() and native_irq_enable() are equally referenced by address in arch/x86/kernel/paravirt.c and thus should suffer from the same problem. Can you explain?
Thanks, -- Jean Delvare SUSE L3 Support
| |