Messages in this thread | | | Subject | Re: [PATCH v3 2/2] virtio_balloon: replace oom notifier with shrinker | From | Tetsuo Handa <> | Date | Fri, 3 Aug 2018 21:11:09 +0900 |
| |
On 2018/08/03 17:32, Wei Wang wrote: > +static int virtio_balloon_register_shrinker(struct virtio_balloon *vb) > +{ > + vb->shrinker.scan_objects = virtio_balloon_shrinker_scan; > + vb->shrinker.count_objects = virtio_balloon_shrinker_count; > + vb->shrinker.batch = 0; > + vb->shrinker.seeks = DEFAULT_SEEKS;
Why flags field is not set? If vb is allocated by kmalloc(GFP_KERNEL) and is nowhere zero-cleared, KASAN would complain it.
> + > + return register_shrinker(&vb->shrinker); > +}
| |