lkml.org 
[lkml]   [2018]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 00/46] Use dmaenginem_async_device_register to simplify code
    On Fri, Aug 03, 2018 at 11:20:49AM +0300, Peter Ujfalusi wrote:
    > Hi,
    >
    > On 2018-08-03 10:19, Huang Shijie wrote:
    > > All the patches are using dmaenginem_async_device_register to simplify code
    > > except the last one:
    > > dmaengine: add COMPILE_TEST for the drivers
    > >
    > > I use the last one to do the compiler test.
    > > There are still 20 drivers which do not use the dmaenginem_async_device_register.
    > > Let me take a rest, if this patch set is accepted, I will do the rest.
    >
    > I think for most of the drivers this series is going to open a race
    > which is essentially:
    >
    > prior:
    > _remove()
    > {
    > ...
    > dma_async_device_register()
    > /* Free resources, disable HW, etc */
    > return 0;
    > }
    >
    > after:
    > _remove()
    > {
    > ...
    > /* Free resources, disable HW, etc */
    > /*
    > * The dma device is still registered and a channel can be
    > * requested
    > */
    >
    > dma_async_device_register()
    > return 0;
    > }
    >
    > It might be theoretical, but conversion to managed device resources is
    > not straight forward in some cases.
    Yes.

    okay, let me think again..

    @Vinod, please just ignore this patch set.

    Thanks
    Huang Shijie

    \
     
     \ /
      Last update: 2018-08-03 10:48    [W:2.512 / U:0.692 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site