Messages in this thread | | | From | Cong Wang <> | Date | Wed, 29 Aug 2018 12:07:09 -0700 | Subject | Re: [PATCH] net: sched: Fix memory exposure from short TCA_U32_SEL |
| |
On Mon, Aug 27, 2018 at 5:03 PM Al Viro <viro@zeniv.linux.org.uk> wrote: > > On Mon, Aug 27, 2018 at 02:31:41PM -0700, Cong Wang wrote: > > > I cant think of any challenges. Cong/Jiri? Would it require development > > > time classifiers/actions/qdiscs to sit in that directory (I suspect you > > > dont want them in include/net). > > > BTW, the idea of improving grep-ability of the code by prefixing the > > > ops appropriately makes sense. i.e we should have ops->cls_init, > > > ops->act_init etc. > > > > Hmm? Isn't struct tcf_proto_ops used and must be provided > > by each tc filter module? How does it work if you move it into > > net/sched/* for out-of-tree modules? Are they supposed to > > include "..../net/sched/tcf_proto.h"?? Or something else? > > If you care about out-of-tree modules, that could easily live in > include/net/tcf_proto.h, provided that it's not pulled by indirect > includes into hell knows how many places. Try > make allmodconfig > make >/dev/null 2>&1 > find -name '.*.cmd'|xargs grep sch_generic.h > > That finds 2977 files here, most of them having nothing to do with > net/sched.
Moving it to include/net/tcf_proto.h is fine, as out-of-tree modules can still compile by modifying the included header path.
include/net/pkt_cls.h might be a choice here too.
| |