lkml.org 
[lkml]   [2018]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] irqchip/gic-v3-its: Move ITS' ->pend_page allocation into an early CPU up callback
On 2018-08-06 09:15:32 [+0100], Marc Zyngier wrote:
> Hi Sebastian,
Hi Marc,

> I must say I'm not overly keen on the extra hotplug notifier, and I'd
> rather allocate all the memory upfront on the boot CPU.
>
> I've implemented this as part of a series that is required for
> kexec/kdump support[1] (and specifically this[2] patch). Could you
> please have a look and let me know if that works for you? I otherwise
> plan to post it for review once the 4.19 merge window has closed.

This looks good, thank you. I can't test this because I don't have a
GICv3 box atm. The last one I had died somehow.
I pull that patch into my next RT release and ask for some feedback.
One question: You have
its_allocate_pending_table(GFP_NOWAIT);

for the allocation. Shouldn't GFP_KERNEL do the job, too?

> Thanks,
>
> M.

Sebastian

\
 
 \ /
  Last update: 2018-08-29 18:50    [W:0.050 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site