Messages in this thread | | | Subject | Re: [PATCH v2] x86/nmi: Fix some races in NMI uaccess | From | Rik van Riel <> | Date | Wed, 29 Aug 2018 12:06:54 -0400 |
| |
On Wed, 2018-08-29 at 08:47 -0700, Andy Lutomirski wrote: > In NMI context, we might be in the middle of context switching or in > the middle of switch_mm_irqs_off(). In either case, CR3 might not > match current->mm, which could cause copy_from_user_nmi() and > friends to read the wrong memory. > > Fix it by adding a new nmi_uaccess_okay() helper and checking it in > copy_from_user_nmi() and in __copy_from_user_nmi()'s callers. > > Cc: stable@vger.kernel.org > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Nadav Amit <nadav.amit@gmail.com> > Signed-off-by: Andy Lutomirski <luto@kernel.org>
Reviewed-by: Rik van Riel <riel@surriel.com>
-- All Rights Reversed. [unhandled content-type:application/pgp-signature] | |