Messages in this thread | | | From | Sam Protsenko <> | Date | Wed, 29 Aug 2018 17:01:00 +0300 | Subject | Re: [PATCH 2/2] scsi: aic7xxx: Fix build using bare-metal toolchain |
| |
On Wed, Aug 29, 2018 at 9:32 AM, Christoph Hellwig <hch@infradead.org> wrote: > On Tue, Aug 28, 2018 at 05:24:21PM +0300, Sam Protsenko wrote: >> Bare-metal toolchains don't define __linux__, so aic7xxx build with >> bare-metal toolchain is broken. Let's check __KERNEL__ definition >> instead of __linux__ (as this code won't be build for user-space anyway) >> in order to fix that. > > Please just drop the ifdefs entirely. The codebase used to be partially > shared with at least FreeBSD, but these days there is no point in > keeping the compatibility around.
Thanks, Christoph. Will do in v2.
| |