Messages in this thread | | | From | Ioana Ciocoi Radulescu <> | Subject | RE: [PATCH net-next v2 0/2] dpaa2-eth: Move DPAA2 Ethernet driver | Date | Wed, 29 Aug 2018 12:06:44 +0000 |
| |
> -----Original Message----- > From: Dan Carpenter <dan.carpenter@oracle.com> > Sent: Wednesday, August 29, 2018 2:08 PM > To: Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com> > Cc: netdev@vger.kernel.org; davem@davemloft.net; > devel@driverdev.osuosl.org; andrew@lunn.ch; Horia Geanta > <horia.geanta@nxp.com>; Madalin-cristian Bucur > <madalin.bucur@nxp.com>; gregkh@linuxfoundation.org; linux- > kernel@vger.kernel.org; Ioana Ciornei <ioana.ciornei@nxp.com>; Laurentiu > Tudor <laurentiu.tudor@nxp.com> > Subject: Re: [PATCH net-next v2 0/2] dpaa2-eth: Move DPAA2 Ethernet > driver > > There are a few static checker warnings for the driver but only the > first one looks like a possibly real bug.
Thanks for the report, what tool did you use to get these warnings?
> > drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c:1116 dpaa2_eth_stop() > error: uninitialized symbol 'dpni_enabled'.
Will initialize in v3. Not actually a bug, since it's used only as an out param.
> drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c:1671 set_fq_affinity() warn: > 'xps_mask' puts 1024 bytes on stack > drivers/staging/fsl-dpaa2/ethsw/ethsw.c:742 port_vlans_add() error: > uninitialized symbol 'err'. > drivers/staging/fsl-dpaa2/ethsw/ethsw.c:886 port_vlans_del() error: > uninitialized symbol 'err'.
The dpaa2 switch driver is not targeted by the current patchset, so I'll fix these in a separate patch on Greg's staging tree.
Thanks, Ioana
| |