lkml.org 
[lkml]   [2018]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 07/16] sched/core: uclamp: extend cpu's cgroup controller
    On 28-Aug 11:29, Randy Dunlap wrote:
    > On 08/28/2018 06:53 AM, Patrick Bellasi wrote:
    > > +config UCLAMP_TASK_GROUP
    > > + bool "Utilization clamping per group of tasks"
    > > + depends on CGROUP_SCHED
    > > + depends on UCLAMP_TASK
    > > + default n
    > > + help
    > > + This feature enables the scheduler to track the clamped utilization
    > > + of each CPU based on RUNNABLE tasks currently scheduled on that CPU.
    > > +
    > > + When this option is enabled, the user can specify a min and max
    > > + CPU bandwidth which is allowed for each single task in a group.
    > > + The max bandwidth allows to clamp the maximum frequency a task
    > > + can use, while the min bandwidth allows to define a minimum
    > > + frequency a task will always use.
    > > +
    > > + When task group based utilization clamping is enabled, an eventually
    > > + specified task-specific clamp value is constrained by the cgroup
    > > + specified clamp value. Both minimum and maximum task clamping cannot
    > > + be bigger than the corresponding clamping defined at task group level.
    >
    > The 4 lines above should all be indented the same (one tab + 2 spaces).

    Right... then there's definitively something broken with my vim
    reformat shortcut, which sometimes uses spaces instead of tabs :(

    Unfortunately this pattern is not covered by checkpatch, which
    returns not errors/warnings on this patch.

    > > +
    > > + If in doubt, say N.
    > > +

    Anyway, thanks for spotting it... easy fix for the next respin.

    Best,
    Patrick

    --
    #include <best/regards.h>

    Patrick Bellasi

    \
     
     \ /
      Last update: 2018-08-29 10:54    [W:3.642 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site