Messages in this thread | | | Date | Wed, 29 Aug 2018 10:49:13 +0200 | From | Wolfram Sang <> | Subject | Re: [PATCH v3 6/6] mmc: tmio: refactor CLK_CTL bit calculation |
| |
> + if (divisor <= 1) { > + clk_sel = 1; > + clk = 0; > + } else { > + clk_sel = 0; > + /* bit7 set: 1/512, ... bit0 set:1/4, all bits clear: 1/2 */ > + clk = roundup_pow_of_two(divisor) >> 2; > + }
What about
clk_sel = (divisor <= 1); clk = clk_sel ? 0 : (roundup_pow_of_two(divisor) >> 2)
More concise, but I think still readable. I don't mind super much, though.
[unhandled content-type:application/pgp-signature]
| |