Messages in this thread | | | Date | Wed, 29 Aug 2018 09:56:10 +0200 | From | Johan Hovold <> | Subject | Re: [PATCH] option: Do not try to bind to ADB interfaces |
| |
On Mon, Aug 27, 2018 at 06:15:52PM +0200, Bjørn Mork wrote: > Johan Hovold <johan@kernel.org> writes: > > > It would allow for simpler device-id entries, at least when ADB is the > > only blacklisted interface, and may enable ADB for some older entries. > > > > On the other hand, interface class 0xff is indeed supposed to be vendor > > specific as Lars and Greg pointed out, and with status quo we don't > > cause any regressions. If ADB isn't currently available for some device > > due to option binding to that interface, we'll just blacklist it as soon > > we get a report. > > > > So personally I'm not sure it's worth it, but I don't have a strong > > opinion on the matter either. > > +1 > > The adb userspace application is also free to unbind any conflicting > driver, so I don't think blacklisting is strictly necessary. Except to > prevent any confusion caused by bogus ttyUSBx devices.
Right. Let's leave things as they are then.
Thanks, Johan
| |