lkml.org 
[lkml]   [2018]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [perf] perf_event.h ABI visibility question
On Mon, 27 Aug 2018, Peter Zijlstra wrote:

> Something like so then?
>
> diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
> index eeb787b1c53c..f35eb72739c0 100644
> --- a/include/uapi/linux/perf_event.h
> +++ b/include/uapi/linux/perf_event.h
> @@ -144,7 +144,7 @@ enum perf_event_sample_format {
>
> PERF_SAMPLE_MAX = 1U << 20, /* non-ABI */
>
> - __PERF_SAMPLE_CALLCHAIN_EARLY = 1ULL << 63,
> + __PERF_SAMPLE_CALLCHAIN_EARLY = 1ULL << 63, /* non-ABI; internal use */
> };

yes, something like that would be fine.

I am being difficult about this, but from experience when trying to keep
the manpage updated, what seems obvious now will not be so obvious 6
months from now and trying to dig through the git logs / mailing list
archives to verify the purpose of an addition can be a lot of work
sometimes.

Vince

\
 
 \ /
  Last update: 2018-08-28 19:52    [W:0.074 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site