lkml.org 
[lkml]   [2018]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] arm64: PCI: Remove node-local allocations when initialising host controller
    On Tue, Aug 28, 2018 at 04:05:12PM +0100, Punit Agrawal wrote:
    > Memory for host controller data structures is allocated local to the
    > node to which the controller is associated with. This has been the
    > behaviour since support for ACPI was added in
    > commit 0cb0786bac15 ("ARM64: PCI: Support ACPI-based PCI host controller").
    >
    > Drop the node local allocation as there is no benefit from doing so -
    > the usage of these structures is independent from where the controller
    > is located.
    >
    > Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
    > Cc: Catalin Marinas <catalin.marinas@arm.com>
    > Cc: Will Deacon <will.deacon@arm.com>
    > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
    > Cc: linux-arm-kernel@lists.infradead.org
    > ---
    > arch/arm64/kernel/pci.c | 5 ++---
    > 1 file changed, 2 insertions(+), 3 deletions(-)

    Acked-by: Will Deacon <will.deacon@arm.com>

    Will

    > diff --git a/arch/arm64/kernel/pci.c b/arch/arm64/kernel/pci.c
    > index 0e2ea1c78542..bb85e2f4603f 100644
    > --- a/arch/arm64/kernel/pci.c
    > +++ b/arch/arm64/kernel/pci.c
    > @@ -165,16 +165,15 @@ static void pci_acpi_generic_release_info(struct acpi_pci_root_info *ci)
    > /* Interface called from ACPI code to setup PCI host controller */
    > struct pci_bus *pci_acpi_scan_root(struct acpi_pci_root *root)
    > {
    > - int node = acpi_get_node(root->device->handle);
    > struct acpi_pci_generic_root_info *ri;
    > struct pci_bus *bus, *child;
    > struct acpi_pci_root_ops *root_ops;
    >
    > - ri = kzalloc_node(sizeof(*ri), GFP_KERNEL, node);
    > + ri = kzalloc(sizeof(*ri), GFP_KERNEL);
    > if (!ri)
    > return NULL;
    >
    > - root_ops = kzalloc_node(sizeof(*root_ops), GFP_KERNEL, node);
    > + root_ops = kzalloc(sizeof(*root_ops), GFP_KERNEL);
    > if (!root_ops) {
    > kfree(ri);
    > return NULL;
    > --
    > 2.18.0
    >

    \
     
     \ /
      Last update: 2018-08-28 18:45    [W:4.051 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site