Messages in this thread | | | From | Rob Herring <> | Date | Tue, 28 Aug 2018 10:04:22 -0500 | Subject | Re: [PATCH] drm: Convert to using %pOFn instead of device_node.name |
| |
On Tue, Aug 28, 2018 at 7:54 AM Maarten Lankhorst <maarten.lankhorst@linux.intel.com> wrote: > > Op 28-08-18 om 03:52 schreef Rob Herring: > > In preparation to remove the node name pointer from struct device_node, > > convert printf users to use the %pOFn format specifier. > > > > Cc: Gustavo Padovan <gustavo@padovan.org> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > Cc: Sean Paul <sean@poorly.run> > > Cc: David Airlie <airlied@linux.ie> > > Cc: Rob Clark <robdclark@gmail.com> > > Cc: dri-devel@lists.freedesktop.org > > Cc: linux-arm-msm@vger.kernel.org > > Cc: freedreno@lists.freedesktop.org > > Signed-off-by: Rob Herring <robh@kernel.org> > > --- > > drivers/gpu/drm/drm_modes.c | 4 ++-- > > drivers/gpu/drm/msm/hdmi/hdmi.c | 2 +- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c > > index 02db9ac82d7a..24a750436559 100644 > > --- a/drivers/gpu/drm/drm_modes.c > > +++ b/drivers/gpu/drm/drm_modes.c > > @@ -716,8 +716,8 @@ int of_get_drm_display_mode(struct device_node *np, > > if (bus_flags) > > drm_bus_flags_from_videomode(&vm, bus_flags); > > > > - pr_debug("%pOF: got %dx%d display mode from %s\n", > > - np, vm.hactive, vm.vactive, np->name); > > + pr_debug("%pOF: got %dx%d display mode\n", > > + np, vm.hactive, vm.vactive); > Aren't you removing it here instead of converting?
Well, yes. The full path and name are already printed so the node name alone was pretty redundant.
Rob
| |