Messages in this thread | | | Date | Tue, 28 Aug 2018 18:01:30 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] ipmi: msghandler: ensure error value in rv is being returned on error |
| |
On Tue, Aug 28, 2018 at 03:36:42PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Currently ipmi_set_my_LUN returns 0 instead of -EINVAL if the channel > is out of range. Fix this by returning the error return rv instead of 0. > > Detected by Clang ("variable 'rv' set but not used") > > Fixes: 048f7c3e352e ("ipmi: Properly release srcu locks on error conditions") > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Somebody just sent that some hours ago.
regards, dan carpenter
| |