lkml.org 
[lkml]   [2018]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe:Re: [PATCH v2] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB


Thanks for your suggestion. Should I send another patch?







At 2018-08-28 21:23:05, "Boris Brezillon" <boris.brezillon@bootlin.com> wrote:
>On Tue, 28 Aug 2018 21:21:16 +0800
>Liu Xiang <liu.xiang6@zte.com.cn> wrote:
>
>> If the size of spi-nor flash is larger than 16MB, the read_opcode
>> is set to SPINOR_OP_READ_1_1_4_4B, and fsl_qspi_get_seqid() will
>> return -EINVAL when cmd is SPINOR_OP_READ_1_1_4_4B. This can
>> cause read operation fail.
>>
>> ---
>> v2:
>> add Fixes tag and CC stable suggested by Boris.
>> ---
>
>The above changelog
>
>>
>> Fixes: e46ecda764dc ("mtd: spi-nor: Add Freescale QuadSPI driver")
>> Cc: <stable@vger.kernel.org>
>> Signed-off-by: Liu Xiang <liu.xiang6@zte.com.cn>
>> ---
>
>should be placed here.
>
>> drivers/mtd/spi-nor/fsl-quadspi.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
>> index 7d9620c..64304a3 100644
>> --- a/drivers/mtd/spi-nor/fsl-quadspi.c
>> +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
>> @@ -478,6 +478,7 @@ static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd)
>> {
>> switch (cmd) {
>> case SPINOR_OP_READ_1_1_4:
>> + case SPINOR_OP_READ_1_1_4_4B:
>> return SEQID_READ;
>> case SPINOR_OP_WREN:
>> return SEQID_WREN;
\
 
 \ /
  Last update: 2018-08-28 16:19    [W:0.034 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site