Messages in this thread | | | Subject | Re: [PATCH] ath10k: use struct_size() in kzalloc() | From | Kalle Valo <> | Date | Tue, 28 Aug 2018 13:43:20 +0000 (UTC) |
| |
"Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote:
> One of the more common cases of allocation size calculations is finding > the size of a structure that has a zero-sized array at the end, along > with memory for some number of elements for that array. For example: > > struct foo { > int stuff; > void *entry[]; > }; > > instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL); > > Instead of leaving these open-coded and prone to type mistakes, we can > now use the new struct_size() helper: > > instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL); > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > Reviewed-by: Kees Cook <keescook@chromium.org> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
06ae8dc00433 ath10k: use struct_size() in kzalloc()
-- https://patchwork.kernel.org/patch/10574741/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |