Messages in this thread | | | Date | Mon, 27 Aug 2018 10:06:13 +0200 | From | Boris Brezillon <> | Subject | Re: [PATCH] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB |
| |
On Sat, 18 Aug 2018 17:14:23 +0800 Liu Xiang <liu.xiang6@zte.com.cn> wrote:
> If the size of spi-nor flash is larger than 16MB, the read_opcode > is set to SPINOR_OP_READ_1_1_4_4B, and fsl_qspi_get_seqid() will > return -EINVAL when cmd is SPINOR_OP_READ_1_1_4_4B. This can > cause read operation fail. > > Signed-off-by: Liu Xiang <liu.xiang6@zte.com.cn>
I'm pretty sure you want to backport this fix. Can you add a Fixes tag and CC stable?
Also, I'd like to have an Ack from someone working at NXP (Han, Yogesh?).
Thanks,
Boris.
> --- > drivers/mtd/spi-nor/fsl-quadspi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c > index 7d9620c..64304a3 100644 > --- a/drivers/mtd/spi-nor/fsl-quadspi.c > +++ b/drivers/mtd/spi-nor/fsl-quadspi.c > @@ -478,6 +478,7 @@ static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd) > { > switch (cmd) { > case SPINOR_OP_READ_1_1_4: > + case SPINOR_OP_READ_1_1_4_4B: > return SEQID_READ; > case SPINOR_OP_WREN: > return SEQID_WREN;
| |