Messages in this thread | | | Date | Sat, 25 Aug 2018 19:21:14 -0700 | From | Matthew Wilcox <> | Subject | Re: [PATCH v1] tools/vm/slabinfo.c: fix sign-compare warning |
| |
On Fri, Aug 24, 2018 at 06:32:14PM +0900, Naoya Horiguchi wrote: > - int hwcache_align, object_size, objs_per_slab; > - int sanity_checks, slab_size, store_user, trace; > + int hwcache_align, objs_per_slab; > + int sanity_checks, store_user, trace; > int order, poison, reclaim_account, red_zone; > + unsigned int object_size, slab_size;
Surely hwcache_align and objs_per_slab can't be negative either? Nor the other three. So maybe convert all seven of these variables to unsigned int?
| |