Messages in this thread | | | Subject | Re: [PATCHv2 2/2] phy:phy-lantiq-rcu-usb2: Use PTR_ERR_OR_ZERO to replace the open coded version | From | Hauke Mehrtens <> | Date | Sat, 25 Aug 2018 16:16:40 +0200 |
| |
On 08/16/2018 05:58 PM, zhong jiang wrote: > PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So > just replace them rather than duplicating its implement. > > Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
> --- > drivers/phy/lantiq/phy-lantiq-rcu-usb2.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/phy/lantiq/phy-lantiq-rcu-usb2.c b/drivers/phy/lantiq/phy-lantiq-rcu-usb2.c > index 986224f..a918c5b 100644 > --- a/drivers/phy/lantiq/phy-lantiq-rcu-usb2.c > +++ b/drivers/phy/lantiq/phy-lantiq-rcu-usb2.c > @@ -196,10 +196,8 @@ static int ltq_rcu_usb2_of_parse(struct ltq_rcu_usb2_priv *priv, > } > > priv->phy_reset = devm_reset_control_get_optional(dev, "phy"); > - if (IS_ERR(priv->phy_reset)) > - return PTR_ERR(priv->phy_reset); > > - return 0; > + return PTR_ERR_OR_ZERO(priv->phy_reset); > } > > static int ltq_rcu_usb2_phy_probe(struct platform_device *pdev) >
| |