Messages in this thread | | | From | "Rafael J. Wysocki" <> | Date | Sat, 25 Aug 2018 13:21:44 +0200 | Subject | Re: [PATCH] cpuidle: menu: Retain tick when shallow state is selected |
| |
On Fri, Aug 24, 2018 at 5:52 PM Doug Smythies <dsmythies@telus.net> wrote: > > On 2018.08.24 02:44 Rafael J. Wysocki wrote: > > On Tuesday, August 21, 2018 10:44:10 AM CEST Rafael J. Wysocki wrote: > >> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > >> > >> The case addressed by commit 5ef499cd571c (cpuidle: menu: Handle > >> stopped tick more aggressively) in the stopped tick case is present > >> when the tick has not been stopped yet too. > > ... [snip] ... > > >> Fixes: 87c9fe6ee495 (cpuidle: menu: Avoid selecting shallow states with stopped tick) > > ... [snip] ... > > > Due to the lack of objections, I'm inclined to queue this up. > > I have been following these threads. > Recall that I was involved, over a period of months, in the original > "powernightmare" stuff. > I have revived my tests (and wish I had left myself better notes), and > am establishing a baseline before adding and trying this patch. > My baseline is actually two tests with and without the previous two patches (the ones > that were just sent a couple of days ago in "More power management updates for v4.19-rc1". > I might have those results in some presentable form by later today (it looks O.K.) > Results with this patch will take another couple of days.
Thanks Doug, much appreciated!
This patch has been queued up, but I will wait for your results for a few days before pushing it.
Cheers, Rafael
| |