lkml.org 
[lkml]   [2018]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 10/32] selftests/ftrace: Fix checkbashisms errors
On Fri, 17 Aug 2018 01:33:55 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:

> Fix a test case to make checkbashisms clean.
>
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> ---
> .../trigger/trigger-trace-marker-snapshot.tc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/trigger/trigger-trace-marker-snapshot.tc b/tools/testing/selftests/ftrace/test.d/trigger/trigger-trace-marker-snapshot.tc
> index 79ce7d51350b..df246e505af7 100644
> --- a/tools/testing/selftests/ftrace/test.d/trigger/trigger-trace-marker-snapshot.tc
> +++ b/tools/testing/selftests/ftrace/test.d/trigger/trigger-trace-marker-snapshot.tc
> @@ -39,10 +39,10 @@ test_trace() {
> fi
> echo "testing $line for >$x<"
> match=`echo $line | sed -e "s/>$x<//"`
> - if [ "$line" == "$match" ]; then
> + if [ "$line" = "$match" ]; then
> fail "$line does not have >$x< in it"
> fi
> - let x=$x+2
> + x=$((x+2))

I didn't realize "let" was a bashism. I've been using that on other
shells I believe. But whatever.

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve

> done
> }
>

\
 
 \ /
  Last update: 2018-08-24 23:51    [W:0.430 / U:2.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site