Messages in this thread | | | Subject | Re: [PATCH NET 3/3] net: hns: add configuration constraints for 1000M half | From | "lipeng (Y)" <> | Date | Fri, 24 Aug 2018 14:39:36 +0800 |
| |
On 2018/8/24 11:41, Andrew Lunn wrote: > On Fri, Aug 24, 2018 at 11:42:23AM +0800, Peng Li wrote: >> Hisilicon hip05 and hip06 board network card do not support >> 1000M half configuration. Driver can not config gmac as >> 1000M half. >> >> Signed-off-by: Peng Li <lipeng321@huawei.com> > Hi Peng > > Does the driver remove SUPPORTED_1000baseT_Half from > phydev->supported? If you do that, the PHY should never negotiate > this speed. > > Andrew Hi, Andrew,
The driver has removed SUPPORTED_1000baseT_Half from
phydev->supported.
the code is : #define MAC_GMAC_SUPPORTED \ (SUPPORTED_10baseT_Half \ | SUPPORTED_10baseT_Full \ | SUPPORTED_100baseT_Half \ | SUPPORTED_100baseT_Full \ | SUPPORTED_Autoneg) h->if_support = MAC_GMAC_SUPPORTED; h->if_support |= SUPPORTED_1000baseT_Full; phydev->supported &= h->if_support;
As gmac do not support 1000M half, we add this patch to make sure that no users can set 1000M half in any case.
Thanks
> > . >
| |