lkml.org 
[lkml]   [2018]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 152/217] ieee802154: at86rf230: switch from BUG_ON() to WARN_ON() on problem
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Stefan Schmidt <stefan@datenfreihafen.org>

    [ Upstream commit 20f330452ad8814f2289a589baf65e21270879a7 ]

    The check is valid but it does not warrant to crash the kernel. A
    WARN_ON() is good enough here.
    Found by checkpatch.

    Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ieee802154/at86rf230.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/ieee802154/at86rf230.c
    +++ b/drivers/net/ieee802154/at86rf230.c
    @@ -940,7 +940,7 @@ at86rf230_xmit(struct ieee802154_hw *hw,
    static int
    at86rf230_ed(struct ieee802154_hw *hw, u8 *level)
    {
    - BUG_ON(!level);
    + WARN_ON(!level);
    *level = 0xbe;
    return 0;
    }

    \
     
     \ /
      Last update: 2018-08-23 10:36    [W:2.786 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site