Messages in this thread |  | | Subject | Re: [PATCH v4 2/4] venus: firmware: move load firmware in a separate function | From | Stanimir Varbanov <> | Date | Wed, 22 Aug 2018 15:29:38 +0300 |
| |
Hi Vikash,
On 08/21/2018 08:29 PM, Vikash Garodia wrote: > Hi Stanimir, > > On 2018-08-21 17:38, Stanimir Varbanov wrote: >> Hi Vikash, >> >> On 08/06/2018 04:28 PM, Vikash Garodia wrote: > > <snip> > >>> -int venus_boot(struct device *dev, const char *fwname) >>> +static int venus_load_fw(struct venus_core *core, const char *fwname, >>> + phys_addr_t *mem_phys, size_t *mem_size) >> >> fix indentation > Please let me know which indentation rule is missed out here. As per last > discussion, the parameters on next line should start from open parenthesis. > I see the same being followed above. > Also i have been running checkpatch script and it does not show up any > issue.
run checkpatch with --strict option please.
> Any other script which can be executed to ensure the coding guidelines ? > > <snip> >
-- regards, Stan
|  |