lkml.org 
[lkml]   [2018]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] strparser: remove any offset before parsing messages
    On Tue, Aug 21, 2018 at 09:36:55PM +0200, Dominique Martinet wrote:

    > One of the solutions I had suggested was adding a flag at strparser
    > setup time to only do that pull for users which cannot handle offset,
    > but nobody seemed interested two weeks ago. I can still do that.

    This seems overly complicated.

    > That's still suboptimal, but I don't have any better idea.
    > To properly fix the users, I'd really need help with how bpf works to
    > even know if passing an offset would be possible in the first place, as
    > I do not see how at this time.

    Thanks for clarifying Dominique.
    It seems like we mainly agree that the proposed patch is suboptimal for
    existing clients of the library that use offset correctly (tls).

    It also seems like you've identified that the proper fix is in bpf.
    Regrettably, I cannot help you understand how bpf works because I'm not
    familiar with that code.

    As an aside, I would recommend reaching the netdev FAQ page:
    https://www.kernel.org/doc/Documentation/networking/netdev-FAQ.txt

    It contains helpful hints about how to format email subjects (specifying
    net vs. net-next) and determining when trees are closed (currently
    closed).

    \
     
     \ /
      Last update: 2018-08-21 23:17    [W:3.469 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site