Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH v1 2/5] cpuidle: menu: Record tick delta value in struct menu_device | Date | Tue, 21 Aug 2018 10:34:34 +0200 |
| |
On Sunday, August 12, 2018 6:09:28 PM CEST Leo Yan wrote: > Since the tick delta is used in multiple places in menu_select(), it's > better to use single one variable to record this value; furthermore, for > more readable we can refactor the code to split a separate function to > making decision for stopping tick, which also needs to use tick delta > value as one metric for consideration.
I don't quite agree that allocating more per-CPU memory for readability sake is a good idea, sorry.
Thanks, Rafael
| |