lkml.org 
[lkml]   [2018]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.17 13/42] mlxsw: core_acl_flex_actions: Remove redundant mirror resource destruction
    Date
    4.17-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Nir Dotan <nird@mellanox.com>

    [ Upstream commit caebd1b389708bf3d0465be829480fc706a68720 ]

    In previous patch mlxsw_afa_resource_del() was added to avoid a duplicate
    resource detruction scenario.
    For mirror actions, such duplicate destruction leads to a crash as in:

    # tc qdisc add dev swp49 ingress
    # tc filter add dev swp49 parent ffff: \
    protocol ip chain 100 pref 10 \
    flower skip_sw dst_ip 192.168.101.1 action drop
    # tc filter add dev swp49 parent ffff: \
    protocol ip pref 10 \
    flower skip_sw dst_ip 192.168.101.1 action goto chain 100 \
    action mirred egress mirror dev swp4

    Therefore add a call to mlxsw_afa_resource_del() in
    mlxsw_afa_mirror_destroy() in order to clear that resource
    from rule's resources.

    Fixes: d0d13c1858a1 ("mlxsw: spectrum_acl: Add support for mirror action")
    Signed-off-by: Nir Dotan <nird@mellanox.com>
    Reviewed-by: Jiri Pirko <jiri@mellanox.com>
    Signed-off-by: Ido Schimmel <idosch@mellanox.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/mellanox/mlxsw/core_acl_flex_actions.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/net/ethernet/mellanox/mlxsw/core_acl_flex_actions.c
    +++ b/drivers/net/ethernet/mellanox/mlxsw/core_acl_flex_actions.c
    @@ -862,6 +862,7 @@ static void
    mlxsw_afa_mirror_destroy(struct mlxsw_afa_block *block,
    struct mlxsw_afa_mirror *mirror)
    {
    + mlxsw_afa_resource_del(&mirror->resource);
    block->afa->ops->mirror_del(block->afa->ops_priv,
    mirror->local_in_port,
    mirror->span_id,

    \
     
     \ /
      Last update: 2018-08-21 08:31    [W:3.494 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site