Messages in this thread |  | | From | Richard Weinberger <> | Subject | Re: [PATCH] ubifs: remove unnecessary check in ubifs_log_start_commit | Date | Tue, 21 Aug 2018 08:25:30 +0200 |
| |
Liu Song,
Am Dienstag, 21. August 2018, 05:17:22 CEST schrieb Liu Song: > The value of c->lhead_offs cannot exceed max_len which much > smaller than c->leb_size. So the check will never be true. > Just remove it.
Please explain in more detail why this case is never ever possible. Removing such code needs a good justification.
In general I don't much like such changes for two reasons: 1. They don't fix a problem 2. They are likely to introduce very hard to debug new issues if they are wrong
Thanks, //richard
|  |