Messages in this thread | | | Date | Mon, 20 Aug 2018 21:18:17 +0200 | From | Paul Cercueil <> | Subject | Re: [PATCH] rtc: jz4740: Drop dependency on MACH_INGENIC |
| |
Hi,
Le lun. 20 août 2018 à 21:12, Alexandre Belloni <alexandre.belloni@bootlin.com> a écrit : > On 20/08/2018 20:07:16+0200, Paul Cercueil wrote: >> Depending on MACH_INGENIC prevent us from creating a generic kernel >> that >> works on more than one MIPS board. Instead, we just depend on MIPS >> being >> set. > > Maybe you could consider dropping the whole dependency as we already > know it will build on every architecture.
Well, I didn't really want the Kconfig option to show on the menu when compiling for non-MIPS, since it's only ever useful there.
Should I drop the dependency then?
>> >> Signed-off-by: Paul Cercueil <paul@crapouillou.net> >> --- >> drivers/rtc/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig >> index a2ba5db36145..98c7f19256b1 100644 >> --- a/drivers/rtc/Kconfig >> +++ b/drivers/rtc/Kconfig >> @@ -1608,7 +1608,7 @@ config RTC_DRV_MPC5121 >> >> config RTC_DRV_JZ4740 >> tristate "Ingenic JZ4740 SoC" >> - depends on MACH_INGENIC || COMPILE_TEST >> + depends on MIPS || COMPILE_TEST >> help >> If you say yes here you get support for the Ingenic JZ47xx SoCs >> RTC >> controllers. >> -- >> 2.11.0 >> > > -- > Alexandre Belloni, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
| |