Messages in this thread | | | From | Alan Tull <> | Date | Mon, 20 Aug 2018 13:04:19 -0500 | Subject | Re: [PATCH v2] fpga: dfl: region: Restory symmetry in probe()/remove() |
| |
On Mon, Aug 20, 2018 at 12:54 PM, Moritz Fischer <mdf@kernel.org> wrote: > Hi Alan, > > On Mon, Aug 20, 2018 at 12:46:32PM -0500, Alan Tull wrote: >> On Mon, Aug 20, 2018 at 12:18 PM, Moritz Fischer <mdf@kernel.org> wrote: >> >> Hi Moritz, >> >> > Replace dev_get_drvdata() with platform_get_drvdata() to >> > match the platform_set_drvdata() in the probe function of >> > the platform driver. >> > >> > Fixes commit bb61b9be3e6b ("fpga: dfl: add fpga region platform driver for FME") >> > Signed-off-by: Moritz Fischer <mdf@kernel.org> >> > --- >> > >> > Changes from v1: >> > - Still compile after change ... >> > >> > --- >> > drivers/fpga/dfl-fme-region.c | 2 +- >> >> Thanks for catching this. of-fpga-region.c does a similar thing and >> needs s/dev_set_drvdata/platform_set_drvdata/ in the probe. Could you >> fix it here too?
Actually I should have said something more like s/dev_set_drvdata(dev/platform_set_drvdata(pdev/
> > Yeah, can do in a v3 series ... Will add your Suggested-by: ...
Thanks!
> > Cheers, > > Moritz
| |