lkml.org 
[lkml]   [2018]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH v3] staging: mt7621-mmc: Fix debug macros and their usages
From
Date
On Sun, 2018-08-19 at 13:34 +0200, Greg Kroah-Hartman wrote:
> On Sun, Aug 19, 2018 at 03:35:02PM +0530, Nishad Kamdar wrote:
> > Fixed four debug macros and their usages. Replaced printk with
> > dev_<level> without __func__ or __LINE__ or current->comm and
> > current->pid. Further removed the do {} while(0) loop for single
> > statement macros.
> > Out of the four, replaced all usages of ERR_MSG and IRQ_MSG with
> > dev_err() in the code itself and dropped them from dbg.h.
> > Removed all INIT_MSG usages and dropped it from dgb.h.
> > Issues found by checkpatch.
>
> This needs to be multiple patches. One for each type of macro you are
> deleting/changing, not all lumped together into one big patch.
>
> Plaese fix that up and resend.

I'd also be tempted to add some logging macros like:

#define host_err(host, fmt, ...) \
dev_err(mmc_dev((host)->mmc, fmt, ##__VA_ARGS__)

so that the code flows a little better.

e.g.:

@@ -521,7 +517,7 @@ static void msdc_abort_data(struct msdc_host *host)> {
> struct mmc_command *stop = host->mrq->stop;
> - ERR_MSG("Need to Abort.");
> + dev_err(mmc_dev(host->mmc), "%d -> Need to Abort.\n", host->id);
> msdc_reset_hw(host);
> msdc_clr_fifo(host);

becomes

host_err(host, "%d -> Need to Abort\n", host->id);

etc...

\
 
 \ /
  Last update: 2018-08-20 20:00    [W:0.243 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site