lkml.org 
[lkml]   [2018]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller
Date
Hi Boris,

> -----Original Message-----
> From: Boris Brezillon [mailto:boris.brezillon@bootlin.com]
> Sent: Monday, August 20, 2018 5:40 PM
> To: Naga Sureshkumar Relli <nagasure@xilinx.com>
> Cc: richard@nod.at; absahu@codeaurora.org; linux-kernel@vger.kernel.org;
> marek.vasut@gmail.com; kyungmin.park@samsung.com; frieder.schrempf@exceet.de; linux-
> mtd@lists.infradead.org; miquel.raynal@bootlin.com; nagasureshkumarrelli@gmail.com;
> Michal Simek <michals@xilinx.com>; computersforpeace@gmail.com; dwmw2@infradead.org;
> peterpandong@micron.com
> Subject: Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan
> NAND Flash Controller
>
> On Mon, 20 Aug 2018 10:49:38 +0000
> Naga Sureshkumar Relli <nagasure@xilinx.com> wrote:
>
> >
> > Thanks for your suggestion and are you saying something like Marvell parser patterns for
> nfcv1 as below?
> >
> > static const struct nand_op_parser marvell_nfcv1_op_parser = NAND_OP_PARSER(
> > /* Naked commands not supported, use a function for each pattern */
> > NAND_OP_PARSER_PATTERN(
> > marvell_nfc_read_id_type_exec,
> > NAND_OP_PARSER_PAT_CMD_ELEM(false),
> > NAND_OP_PARSER_PAT_ADDR_ELEM(false,
> MAX_ADDRESS_CYC_NFCV1),
> > NAND_OP_PARSER_PAT_DATA_IN_ELEM(false, 8)),
> > NAND_OP_PARSER_PATTERN(
> > marvell_nfc_erase_cmd_type_exec,
> > NAND_OP_PARSER_PAT_CMD_ELEM(false),
> > NAND_OP_PARSER_PAT_ADDR_ELEM(false,
> MAX_ADDRESS_CYC_NFCV1),
> > NAND_OP_PARSER_PAT_CMD_ELEM(false),
> > NAND_OP_PARSER_PAT_WAITRDY_ELEM(false)),
> > );
> > That means, a separate hook for each pattern, is that you are suggesting?
>
> Yes.

Ok, I will update the driver and will send next version.

Thanks,
Naga Sureshkumar Relli.

\
 
 \ /
  Last update: 2018-08-20 14:22    [W:0.831 / U:0.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site