lkml.org 
[lkml]   [2018]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2] i2c: Remove '-Wno-deprecated-declarations' compiler warning
    From
    Date
    On Sun, 2018-08-19 at 09:46 -0700, Linus Torvalds wrote:
    > On Sun, Aug 19, 2018 at 6:51 AM Sedat Dilek <sedat.dilek@credativ.de> wrote:
    > >
    > > This can be dropped with commit 771c035372a036f83353eef46dbb829780330234
    > > ("deprecate the '__deprecated' attribute warnings entirely and for good")
    > > now in upstream.
    >
    > Could we please just remove the __deprecated use in i2c entirely?
    >
    > As fat as I can tell, it's used for one thing, which is the
    > "attach_adapter" function pointer member in 'struct i2c_driver'.
    >
    > And I think there is _one_ remaining driver using it, namely the
    > powermac "therm_windtunnel" driver.
    >
    > Could somebody who knows the i2c probing just a bit convert that *one*
    > remaining driver, then remove the "attach_adapter" entirely, and also
    > remove this thing?
    >
    > Alternatively, perhaps the driver should be removed? The last actual
    > powermac change to that driver seems to be from August 2009.
    > Everything since has been just cleanup unrelated to that driver code
    > itself (ie spelling fixes, automated coccinelle scripts etc).
    >
    > Added a few people either because they're still officially maintainers
    > of that file, or because they touched the code ten years ago.

    Some people still use those old machines, I'll give a try at fixing the
    driver.

    Paul: Do you still have one of these machines ?

    Cheers
    Ben.

    \
     
     \ /
      Last update: 2018-08-20 04:14    [W:3.185 / U:0.224 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site