lkml.org 
[lkml]   [2018]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] staging: mt7621-mmc: Fix debug macros and their usages
On Sun, Aug 19, 2018 at 03:35:02PM +0530, Nishad Kamdar wrote:
> #define N_MSG(evt, fmt, args...)
> /*
> -do { \
> - if ((DBG_EVT_##evt) & sd_debug_zone[host->id]) { \
> - printk(KERN_ERR TAG"%d -> "fmt" <- %s() : L<%d> PID<%s><0x%x>\n", \
> - host->id, ##args , __FUNCTION__, __LINE__, current->comm, current->pid); \
> - } \
> -} while(0)
> -*/
> -
> -#define ERR_MSG(fmt, args...) \
> -do { \
> - printk(KERN_ERR TAG"%d -> "fmt" <- %s() : L<%d> PID<%s><0x%x>\n", \
> - host->id, ##args, __FUNCTION__, __LINE__, current->comm, current->pid); \
> -} while (0);
> -
> -#if 1
> -//defined CONFIG_MTK_MMC_CD_POLL
> -#define INIT_MSG(fmt, args...)
> -#define IRQ_MSG(fmt, args...)
> -#else
> -#define INIT_MSG(fmt, args...) \
> -do { \
> - printk(KERN_ERR TAG"%d -> "fmt" <- %s() : L<%d> PID<%s><0x%x>\n", \
> - host->id, ##args, __FUNCTION__, __LINE__, current->comm, current->pid); \
> -} while (0);
> -
> -/* PID in ISR in not corrent */
> -#define IRQ_MSG(fmt, args...) \
> -do { \
> - printk(KERN_ERR TAG"%d -> "fmt" <- %s() : L<%d>\n", \
> - host->id, ##args, __FUNCTION__, __LINE__); \
> -} while (0);
> -#endif
> + *if ((DBG_EVT_##evt) & sd_debug_zone[host->id]) { \
> + * dev_err(mmc_dev(host->mmc), "%d -> " fmt "\n", host->id, ##args) \
> + *}
> + */

I'm sorry but this patch doesn't make any sort of sense at all...

regards,
dan carpenter

\
 
 \ /
  Last update: 2018-08-20 11:23    [W:0.082 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site