Messages in this thread | | | Subject | Re: [PATCH 1/2] ip_vti: fix a null pointer deferrence when create vti fallback tunnel | From | Haishuang Yan <> | Date | Mon, 20 Aug 2018 09:58:11 +0800 |
| |
> On 2018年8月20日, at 上午2:27, David Miller <davem@davemloft.net> wrote: > > From: Haishuang Yan <yanhaishuang@cmss.chinamobile.com> > Date: Sun, 19 Aug 2018 15:05:04 +0800 > >> After set fb_tunnels_only_for_init_net to 1, the itn->fb_tunnel_dev will >> be NULL and will cause following crash: > ... >> Reproduce: >> echo 1 > /proc/sys/net/core/fb_tunnels_only_for_init_net >> modprobe ip_vti >> unshare -n >> >> Fixes: 79134e6ce2c9 (net: do not create fallback tunnels for non-default >> namespaces) >> Cc: Eric Dumazet <edumazet@google.com> >> Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com> > > Applied, but please format your Fixes: tag properly next time. > > Do not split up a Fixes tag into multiple lines, no matter how long it > is. And enclose the commit header text in both parenthesis and double > quotes, not just parenthesis. Like ("blah blah blah"), thank you. >
Okay, thanks for reviewing.
| |