Messages in this thread | | | Subject | Re: [PATCH v4 5/6] powerpc: Add show_user_instructions() | From | Joe Perches <> | Date | Thu, 02 Aug 2018 18:22:29 -0700 |
| |
On Thu, 2018-08-02 at 21:42 -0300, Murilo Opsfelder Araujo wrote: > > > diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c [] > > > @@ -1299,6 +1299,46 @@ static void show_instructions(struct pt_regs *regs) > > > pr_cont("\n"); > > > } > > > +void show_user_instructions(struct pt_regs *regs) > > > +{ > > > + int i; > > > + const char *prefix = KERN_INFO "%s[%d]: code: "; > > > + unsigned long pc = regs->nip - (instructions_to_print * 3 / 4 * > > > + sizeof(int)); > > > + > > > + printk(prefix, current->comm, current->pid); > > > > Why not use pr_info() and remove KERN_INFO from *prefix ? > > Because it doesn't compile: > > arch/powerpc/kernel/process.c:1317:10: error: expected ‘)’ before ‘prefix’ > pr_info(prefix, current->comm, current->pid); > ^ > ./include/linux/printk.h:288:21: note: in definition of macro ‘pr_fmt’ > #define pr_fmt(fmt) fmt > ^
What being suggested is using:
pr_info("%s[%d]: code: ", current->comm, current->pid);
| |