lkml.org 
[lkml]   [2018]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Date
SubjectRe: [PATCH] aoe: mark expected switch fall-through
<div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Wed, Aug 1, 2018 at 6:30 PM Gustavo A. R. Silva &lt;<a href="mailto:gustavo@embeddedor.com">gustavo@embeddedor.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">In preparation to enabling -Wimplicit-fallthrough, mark switch cases<br>
where we are expecting to fall through.</blockquote><div><br></div><div>OK, thanks.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c<br>
index 096882e..136dc50 100644<br>
--- a/drivers/block/aoe/aoecmd.c<br>
+++ b/drivers/block/aoe/aoecmd.c<br>
@@ -1137,6 +1137,7 @@ noskb:            if (buf)<br>
                        break;<br>
                }<br>
                bvcpy(skb, f-&gt;buf-&gt;bio, f-&gt;iter, n);<br>
+               /* fall through */<br>
        case ATA_CMD_PIO_WRITE:<br>
        case ATA_CMD_PIO_WRITE_EXT:<br>
                spin_lock_irq(&amp;d-&gt;lock);<br>
-- <br>
2.7.4<br>
<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">  Ed Cashin &lt;<a href="mailto:ecashin@noserose.net" target="_blank">ecashin@noserose.net</a>&gt;</div></div></div>
\
 
 \ /
  Last update: 2018-08-03 02:27    [W:0.044 / U:0.564 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site