Messages in this thread | | | Date | Thu, 2 Aug 2018 14:16:47 +0800 | From | zhong jiang <> | Subject | Re: [PATCH 1/4] driver/scsi/fnic/fnic_trace: Use vzalloc to zero instead of vmalloc+memset |
| |
On 2018/8/1 23:30, Andy Shevchenko wrote: > On Wed, Aug 1, 2018 at 4:26 PM, zhong jiang <zhongjiang@huawei.com> wrote: >> The vzalloc is better than vmalloc+memset, so replace them to make >> the code concise. >> - fnic_trace_buf_p = (unsigned long)vmalloc((trace_max_pages * PAGE_SIZE)); >> + fnic_trace_buf_p = (unsigned long)vzalloc((trace_max_pages * PAGE_SIZE)); > At the same time you may get rid of unnecessary parens. > Thanks , I will repost with the change.
Thanks zhong jiang
| |