Messages in this thread Patch in this message | | | From | oceanhe@zoho ... | Subject | [PATCH] ACPI: nfit: remove redundant assignment if nfit_mem found | Date | Thu, 2 Aug 2018 02:33:11 -0400 |
| |
From: Ocean He <hehy1@lenovo.com>
When nfit_mem is found via list_for_each_entry, it has already been assigned valid value. There is no need to assign it again in the following codes.
Signed-off-by: Ocean He <hehy1@lenovo.com> --- drivers/acpi/nfit/core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c index 7c47900..85dde54 100644 --- a/drivers/acpi/nfit/core.c +++ b/drivers/acpi/nfit/core.c @@ -1048,9 +1048,7 @@ static int __nfit_mem_init(struct acpi_nfit_desc *acpi_desc, break; } - if (found) - nfit_mem = found; - else { + if (!found) { nfit_mem = devm_kzalloc(acpi_desc->dev, sizeof(*nfit_mem), GFP_KERNEL); if (!nfit_mem) -- 1.8.3.1
| |